Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47811: Fix FAST001 and FAST002 ruff rules and update-deps #19

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

stvoutsin
Copy link
Member

@stvoutsin stvoutsin commented Nov 26, 2024

Summary

Fix ruff rules FAST001 & FAST002 introduced in ruff version 0.8.0

This PR addresses this in the following way:

  • Updates the dependencies including ruff
  • Removes the response_model param which is no longer needed
  • Remove pydantic_xml.mypy from pyproject ruff config (otherwise mypy typing check fails)
  • Use lsst-dax-obscore pip package instead of github repo

Tested

  • tox
  • end-end test on data-dev with locally built Docker image

@stvoutsin stvoutsin marked this pull request as ready for review November 26, 2024 22:22
@stvoutsin stvoutsin merged commit c4e61fa into main Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant