DM-47986: Fix dependency constraints on Safir modules #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main safir PyPI module was constraining the major version of safir-logging and safir-arq, which would break the new UWS support by pinning too old of a version of safir-arq. Those major version constraints are too easy to forget to update, so remove them and instead have Safir pull in the latest version. Unfortunately, either approach here potentially creates problems down the road. Hopefully this will be the approach that creates fewer issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main safir PyPI module was constraining the major version of safir-logging and safir-arq, which would break the new UWS support by pinning too old of a version of safir-arq. Those major version constraints are too easy to forget to update, so remove them and instead have Safir pull in the latest version.
Unfortunately, either approach here potentially creates problems down the road. Hopefully this will be the approach that creates fewer issues.