Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45281: Switch to testcontainers from tox-docker #277

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

rra
Copy link
Member

@rra rra commented Jul 23, 2024

In preparation for converting Safir to a monorepo with multiple PyPI modules and thus the nox build system, switch from tox-docker to testcontainers for testing.

In preparation for converting Safir to a monorepo with multiple
PyPI modules and thus the nox build system, switch from tox-docker
to testcontainers for testing.
@rra rra marked this pull request as ready for review July 23, 2024 18:31
@rra rra requested a review from jonathansick July 23, 2024 18:31
Copy link
Member

@jonathansick jonathansick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rra rra merged commit 468babb into main Jul 23, 2024
6 checks passed
@rra rra deleted the tickets/DM-45281 branch July 23, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants