DM-45281: Break apart safir.database for ease of maintenance
#271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert safir.database from a single-file module to a directory and separate the code into internal modules for ease of maintenance. Upcoming PRs will be adding more code to safir.database, and this will avoid dumping all of that code into a single large file.
|
This is purely moving code around, so review is just conceptual. If you think this is a good idea, I can put up a PR to break apart some of the other larger modules. |
rra
changed the title
safir.database for ease of maintenance
jonathansick
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
safir.databasefrom a single-file module to a directory and separate the code into internal modules for ease of maintenance. Upcoming PRs will be adding more code tosafir.database, and this will avoid dumping all of that code into a single large file.