DM-45281: Add new timedelta data types for Pydantic models #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take advantage of the new functional validator support in Pydantic v2 and encapsulate custom timedelta validation as reusable types. The SecondsTimedelta type accept integer or floating-point number of seconds, possibly stringified. The HumanTimedelta type accepts the same, plus the duration strings accepted by parse_timedelta. Unfortunately, sphinx-automodapi apparently doesn't recognize TypeAlias objects as something for which documentation should be generated, even with :include-all-objects:, so references to these new types have to be ignored when generating documentation.
jonathansick
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take advantage of the new functional validator support in Pydantic v2 and encapsulate custom
timedeltavalidation as reusable types. TheSecondsTimedeltatype accept integer or floating-point number of seconds, possibly stringified. TheHumanTimedeltatype accepts the same, plus the duration strings accepted byparse_timedelta.Unfortunately, sphinx-automodapi apparently doesn't recognize
TypeAliasobjects as something for which documentation should be generated, even with:include-all-objects:, so references to these new types have to be ignored when generating documentation.