Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull_requests to GitHubCheckSuiteModel #267

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

fajpunk
Copy link
Member

@fajpunk fajpunk commented Jul 12, 2024

Needed by mobu to decide whether or not to create a check suite.

Confirmed pull_requests is an empty array when the check suite event is not associated with an PR:

{
  "action": "requested",
  "check_suite": {
    "id": 25911226694,
    "node_id": "CS_kwDOL_KXns8AAAAGCG3xRg",
    "head_branch": "main",
    "head_sha": "a956612459352be98b651eef40c315a01039b672",
    "status": "queued",
    "conclusion": null,
    "url": "https://api.github.com/repos/lsst-sqre/dfuchs-test-mobu/check-suites/25911226694",
    "before": "2504ccedcb5663f87dce23225755e3b26dfc6d40",
    "after": "a956612459352be98b651eef40c315a01039b672",
    "pull_requests": [

    ],

@fajpunk fajpunk requested a review from jonathansick July 12, 2024 15:08
Confirmed `pull_requests` is an empty array when the check suite event
is not associated with an PR:

```json
{
  "action": "requested",
  "check_suite": {
    "id": 25911226694,
    "node_id": "CS_kwDOL_KXns8AAAAGCG3xRg",
    "head_branch": "main",
    "head_sha": "a956612459352be98b651eef40c315a01039b672",
    "status": "queued",
    "conclusion": null,
    "url":
"https://api.github.com/repos/lsst-sqre/dfuchs-test-mobu/check-suites/25911226694",
    "before": "2504ccedcb5663f87dce23225755e3b26dfc6d40",
    "after": "a956612459352be98b651eef40c315a01039b672",
    "pull_requests": [

    ],
```
@fajpunk fajpunk force-pushed the tickets/DM-44635/check-suite-pull-requests branch from 667a66b to 0e6ee60 Compare July 12, 2024 15:09
Copy link
Member

@jonathansick jonathansick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@fajpunk fajpunk merged commit dfc5353 into main Jul 12, 2024
6 checks passed
@fajpunk fajpunk deleted the tickets/DM-44635/check-suite-pull-requests branch July 12, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants