Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45137: Switch to a shared Ruff configuration #263

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

rra
Copy link
Member

@rra rra commented Jul 5, 2024

Copy ruff-shared.toml from the new version of the project template and extend it with Safir-specific rules. This will hopefully make it easier to update the shared configuration in multiple repositories.

@rra rra force-pushed the tickets/DM-45137b branch from f8215d0 to 3f8efc4 Compare July 8, 2024 17:25
Copy ruff-shared.toml from the new version of the project template
and extend it with Safir-specific rules. This will hopefully make it
easier to update the shared configuration in multiple repositories.
@rra rra force-pushed the tickets/DM-45137b branch from 3f8efc4 to 0d8fc4f Compare July 10, 2024 23:46
@rra rra marked this pull request as ready for review July 10, 2024 23:46
@rra rra requested a review from jonathansick July 10, 2024 23:47
Copy link
Member

@jonathansick jonathansick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Someday we can rig up an updater either as a squarebot-driven PR, a reusable workflow that checks for the shared rules being up to date, or a more basic make/tox/nox driven command that pulls an updated shared configured file.

@rra rra merged commit 22bc423 into main Jul 12, 2024
6 checks passed
@rra rra deleted the tickets/DM-45137b branch July 12, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants