DM-44444: Use Python 3.12 for GitHub actions #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests should pass once rebased on top of #248. |
jonathansick
approved these changes
May 30, 2024
There was a problem hiding this comment.
Good idea. A while ago I read about GitHub's Variables feature. That could be a nice way to dry out variables like the default Python version. Works either on a per workflow and a repo-wise level I believe. Sorry I haven't taken the initiative to PR this myself already!
For all GitHub Actions that do not use a version matrix to ensure that the code itself works with older versions, use Python 3.12 as the Python version, under the principle that tests unrelated to compatibility should follow the latest supported Python version.
|
Oh, that looks interesting. I'll go ahead and merge this for now, since that looks a bit more complicated to set up, but will then look into it more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all GitHub Actions that do not use a version matrix to ensure that the code itself works with older versions, use Python 3.12 as the Python version, under the principle that tests unrelated to compatibility should follow the latest supported Python version.