DM-44444: Allow database passwords to be SecretStrs #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing a database engine with create_database_engine or create_sync_session, allow the database password to be a SecretStr instead of a str. This simplifies the call for applications that use Pydantic with SecretStr for secrets.
We've switched to Ruff for linting.
Depend on documenteer>=1 instead of an alpha version so that alpha versions aren't picked up by default.
The latest version of requests breaks the docker library.
jonathansick
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing a database engine with create_database_engine or create_sync_session, allow the database password to be a SecretStr instead of a str. This simplifies the call for applications that use Pydantic with SecretStr for secrets.
Fix some places where development dependencies were out of date, and pin requests since the latest version breaks the docker library.