DM-398710: Remove GitHubAppClientFactory.create_app_client #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was mistakenly added with sufficient testing and never worked. The Gidgethub API cannot cache an app JWT with its current API. The documentation now features the correct workflow, which requires manually obtaining the JWT and passing it with each release.
rra
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was mistakenly added with sufficient testing and never worked. The Gidgethub API cannot cache an app JWT with its current API. The documentation now features the correct workflow, which requires manually obtaining the JWT and passing it with each release.
Since this is technically a breaking change, it should be included with the next major release. However, since the API was never usable, there shouldn't be any issue removing it.