Skip to content

Commit

Permalink
Fix parameters in testing/gcs_test.py
Browse files Browse the repository at this point in the history
Some of the parameters in the test for the Google Storage mock were
misspelled. This previously was not caught because that Python library
wasn't typed, but the latest version has types and mypy started
rejecting the misspelled arguments. Fix the spelling.
  • Loading branch information
rra committed Jun 7, 2024
1 parent 2ac97ea commit 88363ff
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/testing/gcs_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def test_mock(mock_gcs: MockStorageClient) -> None:
credentials = google.auth.default()
signing_credentials = impersonated_credentials.Credentials(
source_credentials=credentials,
target_principle="some-service-account",
target_principal="some-service-account",
target_scopes="https://www.googleapis.com/auth/devstorage.read_only",
lifetime=2,
)
Expand Down Expand Up @@ -62,7 +62,7 @@ def test_mock_files(mock_gcs_file: MockStorageClient) -> None:
credentials = google.auth.default()
signing_credentials = impersonated_credentials.Credentials(
source_credentials=credentials,
target_principle="some-service-account",
target_principal="some-service-account",
target_scopes="https://www.googleapis.com/auth/devstorage.read_only",
lifetime=2,
)
Expand Down

0 comments on commit 88363ff

Please sign in to comment.