Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/DM-47216: WET-007 analysis of lsstCam simulated data #1

Merged
merged 10 commits into from
Nov 20, 2024

Conversation

suberlak
Copy link
Contributor

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@suberlak suberlak requested a review from jbkalmbach October 29, 2024 00:09
Copy link

review-notebook-app bot commented Nov 6, 2024

View / edit / reply to this conversation on ReviewNB

jbkalmbach commented on 2024-11-06T17:27:06Z
----------------------------------------------------------------

Also did a good job with that clear blend in the bottom center which is nice to see.


Copy link

review-notebook-app bot commented Nov 6, 2024

View / edit / reply to this conversation on ReviewNB

jbkalmbach commented on 2024-11-06T17:27:06Z
----------------------------------------------------------------

Can you show the intra and extra focal and compare the two shapes? I was finding that TIE does especially poorly when the overlap between intra and extra is reduced due to size or shape differences.


Copy link

review-notebook-app bot commented Nov 6, 2024

View / edit / reply to this conversation on ReviewNB

jbkalmbach commented on 2024-11-06T17:27:07Z
----------------------------------------------------------------

Can you show this and maybe the other plots where you summarize a state in terms of image quality as well since that's a little easier to interpret how much of a differences this makes?


suberlak commented on 2024-11-19T06:48:30Z
----------------------------------------------------------------

Added main plots in terms of contribution to PSF in asec

Copy link
Member

@jbkalmbach jbkalmbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on nbreview. Some small suggestions. Thanks for the bps commands, it's helpful to have that reference.

Copy link
Contributor Author

Added main plots in terms of contribution to PSF in asec


View entire conversation on ReviewNB

@suberlak suberlak merged commit 20118cf into main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants