[Test] Skip tests for dotnet, java and ml/openvino for ethreads=1 #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hukoyu
requested review from
davidchisnall,
paulcallen,
mikbras,
prp and
SeanTAllen
hukoyu
changed the title
davidchisnall
approved these changes
Aug 18, 2020
|
The nighlty build I ran for this PR https://tfsproduks1.visualstudio.com/Ab5352d9a-5ed5-48f2-b767-7f273b55b53c/sgx-lkl/_build/results?buildId=1909&view=results passed core tests for ethreads 1,4 and 8. These 5 tests are skipped in core tests for SGXLKL_ETHREADS=1 as expected. @paulcallen can you also approve and merge please, @davidchisnall approved already. |
|
Also sgx-lkl nightly pipeline run duration drops from 2 hour to 1 hour since ml/openvino test for 1 thread was taking 1 hour untl it timesout. Since we disabled this test for ethreads=1 now pipeline finishes1 hour earlier. |
vtikoo
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sgx-lkl (nightly) build we run tests for different ethreads (SGXLKL_ETHREADS) values: 1, 4, 8
5 tests are failing in sgx-lkl nightly build with SGXLKL_ETHREADS=1 ( 3 java, 1 dotnet, 1 ml/openvino)
#415 (ml/openvino)
#795 (java, helloworld)
#796 (java, read_file, thread)
#797 (dotnet)
We are skipping (disabling) these 5 tests for ETHREADS=1. They will continue to run for ETHREADS > 1 ( 4 and 8)
We will enable these 5 tests after underlying bugs fixed.