Fix 2 tests about mount/umount #75
Conversation
There was a problem hiding this comment.
Please add below config parameters to tst_test test structure initialization in fdatasync03.c file.
.mount_device = 1,
.all_filesystems = 1,
.mntpoint = MNTPOINT,
By enabling above options, test framework will mount the file system at the time of test initialization time.
| #define FILE_SIZE_MB 32 | ||
| #define FILE_SIZE (FILE_SIZE_MB * TST_MB) | ||
| #define MODE 0644 | ||
| #define dev "/dev/vda" | ||
| #define dev "/dev/vdb" |
There was a problem hiding this comment.
Not required now. Please add below config parameters to tst_test test structure initialization in fdatasync03.c file.
.mount_device = 1,
.all_filesystems = 1,
.mntpoint = MNTPOINT,
By enabling above options, test framework will mount the file system at the time of test initialization time.
There was a problem hiding this comment.
@shaikshavali1 can you give more explanation. We are creating test image and mapping to /dev/vdb and /data in config. Why do we need to mount again? Why don't I need to specify /dev/vdb? Why do we need to mount again?
| @@ -45,12 +42,10 @@ static void verify_fdatasync(void) | |||
| if (TST_RET) | |||
| tst_brk(TFAIL | TTERRNO, "fdatasync(fd) failed"); | |||
|
|
|||
| written = tst_dev_bytes_written(dev); | |||
| written = tst_dev_bytes_written(dev); | |||
There was a problem hiding this comment.
Actually indentation was wrong before, now it is correct :)
There was a problem hiding this comment.
@shaikshavali1 I assume LTP_DEV will have the /dev/vdb in it. But how about tst_dev_bytes_written, what should we pass to it?
| @@ -21,13 +21,14 @@ | |||
| #include "lapi/sync_file_range.h" | |||
| #include "check_sync_file_range.h" | |||
|
|
|||
| #define MNTPOINT "mnt_point" | |||
| #define MNTPOINT "/data" | |||
There was a problem hiding this comment.
This is not required. Please add below config parameters to tst_test test structure initialization in fdatasync03.c file.
.mount_device = 1,
.all_filesystems = 1,
.mntpoint = MNTPOINT,
By enabling above options, test framework will mount the file system at the time of test initialization time.
| #define FNAME1 MNTPOINT"/test1" | ||
| #define FNAME2 MNTPOINT"/test2" | ||
| #define FNAME3 MNTPOINT"/test3" | ||
| #define FILE_SZ_MB 32 | ||
| #define FILE_SZ (FILE_SZ_MB * TST_MB) | ||
| #define MODE 0644 | ||
| #define dev "/dev/vdb" |
| @@ -124,10 +125,6 @@ static void setup(void) | |||
| static struct tst_test test = { | |||
| .tcnt = ARRAY_SIZE(testcases), | |||
| .needs_root = 1, | |||
| .mount_device = 1, | |||
There was a problem hiding this comment.
Please add below config parameters to tst_test test structure initialization in fdatasync03.c file.
.mount_device = 1,
.all_filesystems = 1,
.mntpoint = MNTPOINT,
By enabling above options, test framework will mount the file system at the time of test initialization time.
There was a problem hiding this comment.
@shaikshavali1 we have already /data and /dev/vdb mounted. Why are we mounting again? Do we really need to mount again?
Fixes lsds/sgx-lkl#813