-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iris
: Add course chat settings
#9866
base: develop
Are you sure you want to change the base?
Conversation
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if (settingsType == IrisSettingsType.EXERCISE || authCheckService.isAdmin()) { | ||
currentSettings.setEnabled(newSettings.isEnabled()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this happen at all for course chat settings?
public void setIrisCourseChatSettings(IrisCourseChatSubSettings irisCourseChatSettings) { | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a short comment in the boy of this method to justify that it's empty.
public void setIrisCourseChatSettings(IrisCourseChatSubSettings irisCourseChatSettings) { | |
} | |
public void setIrisCourseChatSettings(IrisCourseChatSubSettings irisCourseChatSettings) { | |
// Empty because exercises don't have course chat settings | |
} |
Checklist
General
Server
Client
Motivation and Context
The Iris course level chat currently used the programming chat settings. We want to split these for clarity.
Description
I added a new sub-settings type for the course chat. It works the same as the programming chat settings for now.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
Summary by CodeRabbit
Release Notes
New Features
IrisCourseChatSubSettings
to manage course-specific chat settings.IrisCombinedCourseChatSubSettingsDTO
for better configuration handling.Bug Fixes
Documentation
Tests
These updates enhance the chat capabilities within course settings, providing a more robust user experience.
@coderabbitai ignore