Fix array signature fn (List(a)) -> Value to fn (List(a), fn (a) -> Value) -> Value
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghivert
changed the title
fn (List(a)) -> Value to fn (List(a), fn (a) -> Value) -> Valuearray signature fn (List(a)) -> Value to fn (List(a), fn (a) -> Value) -> Value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pog.arraywas wrong, in the sense that any data could be sent in the parameter. That PR come to fix this.To stay consistent with packages like
json, I decided to provide the converter function as argument ofarray. We could introducepreprocessed_arrayif you think it's useful.