Adding LaserScan frame #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR locally on my fork first for internal review before opening to the official repo
Related Issues & PRs
ouster-lidar#186
ouster-lidar#195
Summary of Changes
Adds a separated LaserScan frame parameter that will be used to, at this moment, only stamp the scan data.
Previously the scan and point cloud had the same orientation when setting the point cloud frame as the value of the sensor frame. After the previous change (ouster-lidar#195), they are off by 180 degrees regardless of which frame you set as the point cloud frame.
Validation