Add portduino platform, encode SPI device in spi_host #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-bennett
force-pushed
the
Portduino-better-SPI
branch
from
6413ce7 to
4e63c53
Compare
mverch67
reviewed
Apr 29, 2024
jp-bennett
force-pushed
the
Portduino-better-SPI
branch
from
4e63c53 to
3898392
Compare
jp-bennett
force-pushed
the
Portduino-better-SPI
branch
from
3898392 to
858176e
Compare
|
Much simpler, moved the gnarly bits down into the Portduino layer. Also unified the approach between the touch and panel SPI layers. |
|
Looks better now :) |
|
@tobozo what do we think about this approach? |
|
@jp-bennett much lighter, less is more 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mverch and I hashed out the SPI device problem, and what we came up with was a scheme to encode the SPI bus as the lower 4 bits of spi_host, and the device as the upper 4 bits. The change on the Portduino side was to make sure that multiple HardwareSPI objects could be created, and safely point to the same device.