Fixes to Platformio env=native #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the default env to native. That simplifies the usage instructions.
|
hi, Thanks for your contribution 👍 From the readme:
The readme should probably issue a warning about that: modifying the LovyanGFX library like this may make it unusable for other platformio environments, esp-idf, OpenCV, Arduino, etc. Is there a way these files can stay in the platformio project folder? |
Yes, I already fixed that but I made a mistake in editing README-en.md to reflect the solution. d8776a3 fixes it FYI, the M5GFX project uses LovyanGFX and I found the fix in their version - https://github.com/m5stack/M5Unified/tree/master/examples/PlatformIO_SDL |
|
thanks for spotting that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds Windows entries to the include and library paths in examples_for_PC/PlatformIO_SDL/platformio.ini and adds an English language version of the README.md file in that directory. README-en.md contains additional information about final setup, compilation, and running the program under VsCode/PlatformIO that is not in the original version.