fix: drwaer content

[lovegaoshi]

i HATE new arch workarounds HATE HATE HATE HATE

Summary by CodeRabbit

• New Features

  • Enhanced miniplayer functionality with improved height management.
  • Miniplayer now automatically expands to full height upon initialization.

• Bug Fixes

  • Simplified layout height management in playlists component by removing unnecessary conditions.

• Chores

  • Streamlined state management by removing mini player-related properties and methods from the store.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
azusa-player-mobile	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 12, 2024 3:44am

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily focus on the miniplayer functionality across multiple components. The View.tsx in the miniplayer directory has been updated to initialize the miniplayerHeight using a constant value instead of the window height, and an useEffect hook has been added to ensure the miniplayer expands on mount. The View.tsx in the playlists directory simplifies layout logic by removing a condition related to the miniplayer state. Additionally, the APMUIStore interface has been modified to remove properties and methods associated with the miniplayer, streamlining state management.

Changes

File	Change Summary
src/components/miniplayer/View.tsx	- Changed miniplayerHeight initialization to MinPlayerHeight. - Added useEffect to call expand on mount. - Modified dragPlayerHeight to maintain height constraints. - Removed call to miniplayerShrunk in collapse.
src/components/playlists/View.tsx	- Removed condition checking miniPlayerShrunked from onLayout, simplifying layoutHeight state management.
src/stores/useAPMUI.ts	- Removed miniPlayerShrunked property and MiniPlayerShrunk method from APMUIStore interface and implementation. - Removed initialization of miniPlayerShrunked to false.

Possibly related PRs

• feat: headless playback #566: The changes in the main PR regarding the miniplayer's height management and the removal of the miniplayerShrunk callback are related to the modifications in the src/stores/useAPMUI.ts file, which also removes the miniPlayerShrunked property and method, indicating a shift in how the miniplayer's state is managed.
• feat: no repeat #547: The removal of the miniplayerShrunk callback in the main PR aligns with the changes in the src/components/playlists/View.tsx, where the condition checking miniPlayerShrunked was eliminated, simplifying the layout logic and indicating a broader refactor of how the miniplayer's state is handled across components.

🐰 In the meadow where bunnies play,
The miniplayer's height found a new way.
With a hop and a skip, it expands with glee,
No more shrinks, just joy, oh so free!
Simplified layouts, a fresh, bright view,
Hooray for the changes, we celebrate too! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1a09fe4 and 27a020a.

📒 Files selected for processing (3)

• src/components/miniplayer/View.tsx (2 hunks)
• src/components/playlists/View.tsx (1 hunks)
• src/stores/useAPMUI.ts (0 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud