Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown for timezone in maintenance uses the default timezone #5240

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ScottWilliamAnderson
Copy link

Making the dropdown for timezone in maintenance have the default value of the timezone from settings, instead of being empty

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

I'd like to set the default value of the dropdown in the maintenance scheduler to be set to the current value in the server's timezone. This is a very minor QOL improvement for users who often schedule maintenance & would use the same timezone as the server.

I've followed the guidelines from the CONTRIBUTING.md, and would like to have @louislam input if you think this is an appropriate new feature, I will start work on it. Please do share any comments or thoughts you might have.

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

image

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

…e of the timezone from settings, instead of being empty
@Ionys320
Copy link
Contributor

Ionys320 commented Nov 2, 2024

The fix is easy to made, I guess you can submit it and wait for it to be approved. More of that, this should be the default comportment, referring to the Wiki!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants