-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display when the next check will happen as a heartbeat timer #5189
base: master
Are you sure you want to change the base?
Conversation
when the modal is opened, its sets overflow hidden, remove this style so as to unfreeze it
i hadnt saved this T_T
It is not recommended to use `len` for empty string test.
refactor: fix check for empty string
This reverts commit 949198d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments below
Based on your description, this pr might be going into an incorrect direction, and this pr could be much difficult to be implemented that you think. We should have a discussion before we go. Some points come in my mind:
And actually, I have a plan to change the core to Croner (#3447) Croner provides the next run time, which fits for this pr:
I would suggest that this pr should be based on #3447 |
Hey @louislam i do get your point. The thing is since the lastheart gets updated whenever we change the interval (even from other browser, all the related data about it also gets updated. Below is a video attached for ur reference. Video link - https://www.loom.com/share/65820c1c0e624839ac0f7cce6fa78982 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
FYI: pinging me daily will not get your PRs reviewed and merged quicker. If it has been a month and you think your PR has been forgotten, fine... but daily?... |
Please read our pull request rules, rushing is not allowed. And I think you didn't get my point of my previous comment, frontend only timer must be wrong in some cases, because only backend knows the actual next check time. You video didn't cover all possible cases unfortunately. |
Hey first of all i am sorry if it disturbed you a lot. I didnt meant to to cause any trouble to you guys. Secondly, All i was expecting was some communication from you guys stating "sure" "will check it". Since days were passing without any information, I thought this pr is becoming stale. I didnt want to be a trouble in your already busy schdule. Third, if you want more video content covering all test cases do let me know. I wanted to just show for that case. Alternatively if required, you can post the ones which fail here after checking out the code. I do get your point of having this on backend, but its simply uncessary. Once again thank you for replying yesterday. If you guys require something else, do let me kno. Plus just a small quick reminder tht hacktober fest ends in like 11 days. Thank you |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #5120
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
added all test cases to work
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.