Upload artifact after pushing to main #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could be used like a pre-release or for ease to not need to rebuild locally after a fix has been pushed to main
|
Sounds like a good idea, however according to the ci-build.yml logic, will this also upload a new artifact each time a pull request CI starts running? :D arnis/.github/workflows/ci-build.yml Line 5 in 7d0d186 |
That's true.. we can add an if-statement I believe to check for the GH Action trigger |
sebastiaanspeck
commented
Jan 3, 2025
| @@ -38,3 +38,10 @@ jobs: | |||
|
|
|||
| - name: Build | |||
| run: cargo build --release | |||
|
|
|||
| - name: Upload artifact | |||
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' | |||
There was a problem hiding this comment.
Could also be only github.ref == 'refs/heads/main'.
sebastiaanspeck
commented
Jan 3, 2025
sebastiaanspeck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could be used like a pre-release or for ease to not need to rebuild locally after a fix has been pushed to main