Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the codes release/v0.1 to main #17

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

linjie-firework
Copy link
Collaborator

@linjie-firework linjie-firework commented May 20, 2024

Sync the codes release/v0.1 to main

  • CPS-789 [Bug] IOS Flutter SDK- Translation: English is not translated in the Subtitle section
  • CPS-809 Bug fix: [Flutter SDK] [RTL] Some of the images/texts are in the wrong direction
  • CPS-819 Fix warning: Forming 'UnsafeRawPointer' to an inout variable of type String exposes the internal representation rather than the string contents.
  • CPS-830 Bug fix: iOS RN SDK - DS - Invalid access token overlaps with the icon

…g direction (#15)

* Bug fix: [Flutter SDK] [RTL] Some of the images/texts are in the wrong direction

* Update UIView+AppLanguage.swift
…String exposes the internal representation rather than the string contents. (#16)
@linjie-firework linjie-firework requested a review from spookyd May 20, 2024 14:44
…th the icon (#18)

* Bug fix: CPS-830

* Update FireworkVideoUI.podspec
@linjie-firework linjie-firework requested review from haitaoshangguan and removed request for spookyd May 30, 2024 04:40
Copy link

@haitaoshangguan haitaoshangguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linjie-firework linjie-firework merged commit fc6b72f into main May 30, 2024
1 check passed
@linjie-firework linjie-firework deleted the sync_release_v0.1 branch June 27, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants