Bug fix: [Flutter SDK] [RTL] Some of the images/texts are in the wrong direction #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spookyd
reviewed
May 17, 2024
Comment on lines
+11
to
+13
| private let gNamesOfImagesWithDirection: [String] = [ | ||
| "c3RyZWFtLWdhdGUtYmFjaw==".decodeBase64String(), | ||
| ] |
There was a problem hiding this comment.
This base64 decoded string seems to be referencing and internal image of the FireworkVideoSDK. This is extremely fragile. What is the intent on this?
There was a problem hiding this comment.
I didn't find the other way instead of hardcoding FireworkVideoSDK image names here. The image is used in SwiftUI. We don't have another way to check whether the image should be flipped. For the image used in UIImageView, we could check the flipsForRightToLeftLayoutDirection property. But we can't find the related property in SwiftUI.
linjie-firework
added a commit
that referenced
this pull request
May 20, 2024
…g direction (#15) * Bug fix: [Flutter SDK] [RTL] Some of the images/texts are in the wrong direction * Update UIView+AppLanguage.swift
linjie-firework
added a commit
that referenced
this pull request
May 30, 2024
* [Bug] IOS Flutter SDK- Translation: English is not translated in the Subtitle section (#14) * Bug fix: [Flutter SDK] [RTL] Some of the images/texts are in the wrong direction (#15) * Bug fix: [Flutter SDK] [RTL] Some of the images/texts are in the wrong direction * Update UIView+AppLanguage.swift * Fix warning: Forming 'UnsafeRawPointer' to an inout variable of type String exposes the internal representation rather than the string contents. (#16) * [CPS-830] Bug fix: iOS RN SDK - DS - Invalid access token overlaps with the icon (#18) * Bug fix: CPS-830 * Update FireworkVideoUI.podspec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective 🎯
Ticket: CPS-809
Changes 💥