Update to ASDK v6.10.0 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsenoid
requested review from
a team and
OstapOpalynskyi-fw
and removed request for
a team
mohsenoid
commented
Mar 26, 2024
| @@ -64,6 +64,7 @@ android { | |||
|
|
|||
| buildFeatures { | |||
| compose = true | |||
| buildConfig = true | |||
There was a problem hiding this comment.
Solves a Gradle warning
mohsenoid
commented
Mar 26, 2024
| @@ -14,7 +14,6 @@ class ExampleApplication : Application() { | |||
| // build Firework Android SDK v6 configuration | |||
| val config = | |||
| FireworkSdkConfig.Builder(this) | |||
| .checksumRequired(false) | |||
mohsenoid
commented
Mar 26, 2024
| @@ -1,12 +1,11 @@ | |||
| // Top-level build file where you can add configuration options common to all sub-projects/modules. | |||
| plugins { | |||
| id("com.android.application") version "8.2.2" apply false | |||
| id("com.android.library") version "8.2.2" apply false | |||
mohsenoid
commented
Mar 26, 2024
| @@ -1,12 +1,11 @@ | |||
| // Top-level build file where you can add configuration options common to all sub-projects/modules. | |||
| plugins { | |||
| id("com.android.application") version "8.2.2" apply false | |||
| id("com.android.library") version "8.2.2" apply false | |||
| id("com.android.application") version "8.3.1" apply false | |||
There was a problem hiding this comment.
Updated to the latest
mohsenoid
commented
Mar 26, 2024
| id("org.jetbrains.kotlin.android") version "1.9.22" apply false | ||
| id("org.jlleitschuh.gradle.ktlint") version "12.0.3" apply false | ||
| id("io.gitlab.arturbosch.detekt") version "1.23.4" apply false | ||
| } | ||
|
|
||
| task<Delete>("clean") { | ||
| delete = setOf(rootProject.buildDir) |
mohsenoid
commented
Mar 26, 2024
| @@ -21,5 +21,4 @@ kotlin.code.style=official | |||
| # resources declared in the library itself and none from the library's dependencies, | |||
| # thereby reducing the size of the R class for that library | |||
| android.nonTransitiveRClass=true | |||
| android.defaults.buildfeatures.buildconfig=true | |||
There was a problem hiding this comment.
Deprecated and causes a warning
mohsenoid
commented
Mar 26, 2024
| @@ -1,6 +1,6 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.2-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip | |||
mohsenoid
commented
Mar 26, 2024
| @@ -11,6 +11,7 @@ dependencyResolutionManagement { | |||
| repositories { | |||
| google() | |||
| mavenCentral() | |||
| mavenLocal() | |||
There was a problem hiding this comment.
Nice to have for testing before release
OstapOpalynskyi-fw
approved these changes
Mar 26, 2024
mohsenoid
force-pushed
the
update/6.10.0
branch
3 times, most recently
from
1d53cc0 to
6d8e5f5
Compare
mohsenoid
commented
Mar 26, 2024
| @@ -46,10 +46,15 @@ android { | |||
| abortOnError = true | |||
| ignoreWarnings = false | |||
| warningsAsErrors = true | |||
|
|
|||
| disable.apply { | |||
| add("LeanbackUsesWifi") // required for ivs-player-1.18.0 AndroidManifest ACCESS_WIFI_STATE permission | |||
mohsenoid
force-pushed
the
update/6.10.0
branch
from
6d8e5f5 to
d372192
Compare
Signed-off-by: Mohsen Mirhoseini <[email protected]>
mohsenoid
force-pushed
the
update/6.10.0
branch
from
d372192 to
e716225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.