Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue#663 on branch 6.x #741

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix for issue#663 on branch 6.x #741

merged 1 commit into from
Dec 11, 2024

Conversation

manarhusrieh
Copy link

@manarhusrieh manarhusrieh commented Dec 9, 2024

Fixes: #663 #610

This is a rebase of the PR #666 on branch 6.x

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits

  • npm test passes on your machine
    image

  • New tests added or existing tests modified to cover all changes

  • Code conforms with the style guide

  • Commit messages are following our guidelines

Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on the approval/review on PR #666

@dhmlau
Copy link
Member

dhmlau commented Dec 11, 2024

Force merging this PR as tests pass on local machine.

@dhmlau dhmlau merged commit d01a859 into loopbackio:6.x Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants