(perf) Filter construction improvements - Make It Smarter #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix - pass in the parameters to the big query generate model * make it smater * merge * prevent duplicate triggering of generation * move logic into helper utils * fix state * fix the callbacks * use params instead of a string * add back sorting * fix link generation * remove some consoles * check the filters twice, make sure that we're returning a simpler data structure * fix race condition for page load * separate call for filter and visualization generation * fix typescript errors * add jest tests * update for edge cases when custom urls, and custom dates are in examples need to be handled. * Fix package json * more fixes post merge * fix the store * fix sidepanel * fix the link to explore * improve speed by parallelizing calls to gemini * fix summarization * scroll into view * add filter helper and tests * add tests * run on every commit * only use node 16 and 18 * use a filter validator * remove un-used console logs * post-merge fixes * fix tests * improve scrolling --------- Co-authored-by: Jawad Laraqui <[email protected]> Co-authored-by: Flavio Di Berardino <[email protected]>
Added case statement to handle both cleaned an uncleaned urls
adding more context to filter doc on dates
Adding context file on timeframes and intervals
adding import and reference for context
updating file
|
@colin-roy-ehri please remove the duplicative filter documentation/context from the useSendVertexMessage.ts |
reverted/removed inline date and number filter documentation in useSendVertexMessage
…tecode Make it smarter more context bytecode
…tecode Make it smarter more context bytecode
Adding more context to distinguish between last x days and x days ago type of filters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeframe and interval context file to documents directory, added more explicit context to the looker_filter_doc.md file, updated useSendVertexMessage.ts file to include interval and timeframe context file.