feat(url Query): Added an optional URL query parameter #116
Conversation
|
Hi Colin, this along with your other PRs look really interesting I would love to implement something similar. I understand the code in your commit but would you mind explaining a bit on how you integrated this with the dashboard summary app? Thanks. |
|
Hi Ryan!
I had changed the Dashboard sumary app by making it generate query links to
the explore assistant, so a user could follow recommended next steps by
gathering more data. Integrated it with a direct link, by allowing a user
to link from the query summary page to the explore assistant in a new tab.
The dashboard summary code isn't quite ready for pr yet, because some of my
changes broke the extension when it is loaded in a dashboard 'mount point'.
Should have that fixed tomorrow.
Thanks,
Colin
…On Mon, Oct 14, 2024, 10:43 AM Ryan Gould ***@***.***> wrote:
Hi Colin, this along with your other PRs look really interesting I would
love to implement something similar. I understand the code in your commit
but would you mind explaining a bit on how you integrated this with the
dashboard summary app? Thanks.
—
Reply to this email directly, view it on GitHub
<#116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJNRP4UR4CFW3BNYUZXD7SDZ3PYD7AVCNFSM6AAAAABPX3G2TCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJRG43DCMBTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
There was a problem hiding this comment.
Very interesting! Am I correct in that, this makes the assumption that the default LookML Model and Explore set as the source for the Explore Assistant will be used?
Copying the following from another file. Given that Explore Assistant now supports and could have multiple Model & Explore combinations to choose from, I think it would be valuable to have 2 other queryParams in the url: one that sets the model and the other that sets the explore. Then we can update the state using something like this:
// set the explore if it is not set dispatch( updateCurrentThread({ exploreId: <New Explore ID>, modelName: <Model URL Param>, exploreKey: <Explore URL Param> }), )
|
I agree, I had thought of it also. I'll try to get it in soon.
…On Wed, Oct 23, 2024, 10:00 AM Luka Fontanilla ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Very interesting! Am I correct in that, this makes the assumption that the
default LookML Model and Explore set as the source for the Explore
Assistant will be used?
Copying the following from another file. Given that Explore Assistant now
supports and could have multiple Model & Explore combinations to choose
from, I think it would be valuable to have 2 other queryParams in the url:
one that sets the model and the other that sets the explore. Then we can
update the state using something like this:
// set the explore if it is not set dispatch( updateCurrentThread({
exploreId: <New Explore ID>, modelName: <Model URL Param>, exploreKey:
<Explore URL Param> }), )
—
Reply to this email directly, view it on GitHub
<#116 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJNRP4T6TAOITWX7UDWAER3Z47B2RAVCNFSM6AAAAABPX3G2TCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBZGI4TSMZSGU>
.
You are receiving this because you authored the thread.Message ID:
<looker-open-source/looker-explore-assistant/pull/116/review/2389299325@
github.com>
|
The new url query parameter queryPrompt will automatically enter the query and execute it. This allows other apps to call this app with a pre-defined initial query.
For example, you can make the Dashboard Summary app have follow-up queries which link to the Explore Assistant using this queryPrompt parameter.