Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useSendVertexMessage.ts #102

Open
wants to merge 1 commit into
base: dev-make-it-smarter
Choose a base branch
from

Conversation

dbarrbc
Copy link

@dbarrbc dbarrbc commented Sep 20, 2024

Added code to enable backwards compatability with url examples.

Added code to enable backwards compatability with url examples.

c
@dbarrbc dbarrbc requested a review from a team as a code owner September 20, 2024 20:17
Copy link

google-cla bot commented Sep 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@LukaFontanilla LukaFontanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect the parsing, but the default value for the "vis" parameter should be an object and not an empty array. Line 468 in -> explore-assistant-extension/src/hooks/useSendVertexMessage.ts

@LukaFontanilla
Copy link
Collaborator

The only other that would be important to include in the parser is support for the dynamic_fields param of the url (ie. supporting custom dims, measures and table calculations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants