Add ability to set dataset project id #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmotoyama
force-pushed
the
martimotoyama/configurable-billing-project
branch
3 times, most recently
from
5cd95c6 to
39766b6
Compare
mmotoyama
changed the title
mmotoyama
force-pushed
the
martimotoyama/configurable-billing-project
branch
2 times, most recently
from
a39d3af to
04786cd
Compare
mmotoyama
commented
Nov 27, 2024
mmotoyama
force-pushed
the
martimotoyama/configurable-billing-project
branch
7 times, most recently
from
b986ad2 to
0762d72
Compare
nestorenko
approved these changes
Nov 27, 2024
goomrw
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
thanks for implementing this! i checked coverage on a local run, and it looks good - the only uncovered code was in duplicate invocations to BQSupportFuncts.runSyncQuery and .startQuery, which type checking covers.
i left some nits that you can choose to address or not. if you do, i'll give you a re-review much sooner than i gave you this review!
src/test/java/net/starschema/clouddb/jdbc/PreparedStatementTests.java
Outdated
Show resolved
Hide resolved
mmotoyama
force-pushed
the
martimotoyama/configurable-billing-project
branch
from
0762d72 to
d701a80
Compare
This CL adds the ability to specify a dataset project id as part of the dataset field in the connection string used to create a BQConnection instance. Previously, we used the project defined in the URL's path component for both the billing and default dataset projects. Recall that the default project and dataset are used to disambiguate unqualified table names referenced in a query being processed by a connection. Now, we parse the potentially fully qualified dataset to check for a project id. If no project id is found, we revert back to our former behavior, using the billing project as the default dataset project.
mmotoyama
force-pushed
the
martimotoyama/configurable-billing-project
branch
from
d701a80 to
2a216f0
Compare
mmotoyama
added a commit
that referenced
this pull request
Dec 14, 2024
This CL bumps the minor version of the BQJDBC driver. In a recently merged PR[0], we added the ability to configure a default dataset project id, which is used in conjunction with the dataset id to locate unqualified table references. We added this new capability in a backwards compatible manner. [0] #201
mmotoyama
added a commit
that referenced
this pull request
Dec 17, 2024
This CL bumps the minor version of the BQJDBC driver. In a recently merged PR[0], we added the ability to configure a default dataset project id, which is used in conjunction with the dataset id to locate unqualified table references. We added this new capability in a backwards compatible manner. [0] #201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds the ability to specify a dataset project id as part of the dataset field in the connection string used to create a
BQConnection instance. Previously, we used the project defined in the URL's path component for both the billing and default dataset projects. Recall that the default project and dataset are used to disambiguate unqualified table names referenced in a query being processed by a connection.
Now, we parse the potentially fully qualified dataset to check for a project id. If no project id is found, we revert back to our former behavior, using the billing project as the default dataset project.