Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v2 data engine live upgrade #3282

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

WIP

63665fc
Select commit
Loading
Failed to load commit list.
Open

feat: v2 data engine live upgrade #3282

WIP
63665fc
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor succeeded Nov 27, 2024 in 2s

52 issues fixed. 5 issues found.

Annotations

Check notice on line 3225 in controller/volume_controller.go

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

controller/volume_controller.go#L3225

If block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (indent-error-flow)

Check notice on line 2707 in controller/engine_controller.go

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

controller/engine_controller.go#L2707

Redefinition of the built-in function new. (redefines-builtin-id)

Check notice on line 2679 in controller/engine_controller.go

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

controller/engine_controller.go#L2679

Redefinition of the built-in function new. (redefines-builtin-id)

Check notice on line 3212 in controller/volume_controller.go

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

controller/volume_controller.go#L3212

If block ends with a return statement, so drop this else and outdent its block. (indent-error-flow)

Check notice on line 3957 in datastore/longhorn.go

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

datastore/longhorn.go#L3957

Redefinition of the built-in function min. (redefines-builtin-id)