Modify fio job files to use ConfigMap

[hookak]

I’ve implemented the idea discussed in the issue. This PR depends on the previous #9, so I will make further changes after that PR is merged.

If we use *.fio files in a ConfigMap:

Cons:

• Requires two apply commands to run the workload:

k apply -f fio-config.yaml
k apply -f fio.yaml

Pros:

• Easier to modify workloads through the ConfigMap.

Please review and provide feedback on these points. @derekbit

related: longhorn/longhorn#9100

[derekbit]

Hello @hookak
DCO check failed. Please sign off your commit by git commit -s. Thank you.

[derekbit]

LGTM

[hookak]

Thanks for the review! @derekbit

I’ve implemented the idea discussed in the issue. This PR depends on the previous #9, so I will make further changes after that PR is merged.

As mentioned earlier, there's a dependency on PR #9. Do you have plans to merge that?"

[derekbit]

@hookak
#9 needs to refine later due to #9 (review). Can you update the PR without the dependency on #9? Then, we can merge this PR first. WDYT?

[hookak]

Thanks for the reply, @derekbit.

I reviewed PR #9, but it's difficult to remove the dependency.
It might be better to update this after #9 is merged.

Please let me know once #9 is merged. Thanks!

[derekbit]

@hookak
Can you merge fio-config.yaml into fio.yaml and then delete fio-config.yaml ? After that, we can merge it. Thank you.

content of fio-config.yaml
---
content of fio.yaml

[hookak]

Sure, I can do that. @derekbit
However, if we make the changes, the contents of fio-config.yaml will be duplicated in both fio.yaml and fio-cmp.yaml.
It should be updated as follows. Please review the changes.

[derekbit]

Sure, I can do that. @derekbit However, if we make the changes, the contents of fio-config.yaml will be duplicated in both fio.yaml and fio-cmp.yaml. It should be updated as follows. Please review the changes.

Got it. I'm fine with it if we still want to support one command execution like kubectl apply -f https://raw.githubusercontent.com/yasker/kbench/main/deploy/fio.yaml.

[innobead]

This change will duplicate fio files which we maintain in the fio folder as our default profiling configs.

To prevent duplication, I suggest the below changes:

• make the config map empty by default
• modify run.sh to check whether any customized fio files defined in the config map. If the customized fio file is found, use it, or fallback to use the default one.

[hookak]

I agree with your comment because I also want to avoid duplicate fio files. However, if we make the config maps empty in fio.yaml, it will override custom configs when I want to use them.

Therefore, I suggest creating a fio-custom.yaml for those who want to use custom configs, and checking if any customized fio files are defined in run.sh.
Since most users are expected to use the default config, I think this is a reasonable change.

Could you please review this? @innobead @derekbit