fix node js tests consistently failing (#1861)

lolopinto · Nov 30, 2024 · 8edd300 · 8edd300
1 parent e2a449c
commit 8edd300
Show file tree

Hide file tree

Showing 7 changed files with 49 additions and 46 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -31,7 +31,7 @@ jobs:
         env:
           POSTGRES_PASSWORD: postgres
           name: 'PGOPTIONS'
-          value: '-c max_connections=1000'
+          value: '-c max_connections=200'
         # Set health checks to wait until postgres has started
         options: >-
           --health-cmd pg_isready
@@ -65,7 +65,7 @@ jobs:
 
     - run: npm ci 
     - run: npm run build --if-present 
-    - run: npm test
+    - run: npm test -- --runInBand
       env:
         POSTGRES_PASSWORD: 'postgres'
         POSTGRES_USER: 'postgres'    
diff --git a/examples/simple/src/ent/tests/user_full_text.test.ts b/examples/simple/src/ent/tests/user_full_text.test.ts
@@ -27,7 +27,7 @@ beforeAll(async () => {
       password,
       port: 5432,
       sslmode: "disable",
-      max: 100,
+      max: 200,
     },
     //    log: ["query"],
   });

diff --git a/ts/package-lock.json b/ts/package-lock.json
diff --git a/ts/package.json b/ts/package.json
@@ -49,7 +49,7 @@
     "@swc/core": "^1.3.100",
     "@swc/jest": "^0.2.26",
     "@types/bcryptjs": "^2.4.2",
-    "@types/better-sqlite3": "^7.6.4",
+    "@types/better-sqlite3": "^7.6.12",
     "@types/express": "^4.17.15",
     "@types/glob": "^8.0.0",
     "@types/graphql-upload": "^8.0.12",
@@ -64,7 +64,7 @@
     "@types/pluralize": "0.0.29",
     "@types/supertest": "^2.0.12",
     "@types/uuid": "^9.0.0",
-    "better-sqlite3": "^8.4.0",
+    "better-sqlite3": "^11.6.0",
     "email-addresses": "^5.0.0",
     "express": "^4.18.2",
     "graphql": "^16.8.1",

diff --git a/ts/src/action/orchestrator.test.ts b/ts/src/action/orchestrator.test.ts
@@ -84,27 +84,6 @@ import { randomEmail } from "../testutils/db/value";
 import { toDBColumnOrTable } from "../names/names";
 
 const edges = ["edge", "inverseEdge", "symmetricEdge"];
-beforeEach(async () => {
-  // does assoc_edge_config loader need to be cleared?
-  for (const edge of edges) {
-    await createRowForTest({
-      tableName: "assoc_edge_config",
-      fields: {
-        edge_table: toDBColumnOrTable(edge, "table"),
-        symmetric_edge: edge == "symmetricEdge",
-        inverse_edge_type: edge === "edge" ? "inverseEdge" : "edge",
-        edge_type: edge,
-        edge_name: "name",
-        created_at: new Date(),
-        updated_at: new Date(),
-      },
-    });
-  }
-});
-
-afterEach(() => {
-  FakeComms.clear();
-});
 
 const UserSchema = getBuilderSchemaFromFields(
   {
@@ -526,6 +505,28 @@ function getInsertUserBuilder(
 }
 
 function commonTests() {
+  beforeAll(async () => {
+    // does assoc_edge_config loader need to be cleared?
+    for (const edge of edges) {
+      await createRowForTest({
+        tableName: "assoc_edge_config",
+        fields: {
+          edge_table: toDBColumnOrTable(edge, "table"),
+          symmetric_edge: edge == "symmetricEdge",
+          inverse_edge_type: edge === "edge" ? "inverseEdge" : "edge",
+          edge_type: edge,
+          edge_name: "name",
+          created_at: new Date(),
+          updated_at: new Date(),
+        },
+      });
+    }
+  });
+
+  afterEach(() => {
+    FakeComms.clear();
+  });
+
   test("schema on create", async () => {
     const builder = getInsertUserBuilder(
       new Map([

diff --git a/ts/src/core/db_postgres_parallel.test.ts b/ts/src/core/db_postgres_parallel.test.ts
@@ -29,7 +29,7 @@ test("lots of writes at once", async () => {
       user,
       password,
       database: tdb.getDB(),
-      max: 1000,
+      max: 200,
       host: "localhost",
     },
   });

diff --git a/ts/src/testutils/db/temp_db.ts b/ts/src/testutils/db/temp_db.ts
@@ -510,7 +510,7 @@ export class TempDB {
         DB.initDB({
           connectionString: connStr,
           cfg: {
-            max: 100,
+            max: 200,
             idleTimeoutMillis: 100,
           },
         });