Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added accesibility for links and key on v-for loop #117

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

r0hanc-zz
Copy link

Added accessibility based on https://www.a11ymatters.com/pattern/pagination/
Also added keys in v-for loop

@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #117 into master will increase coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage      78%   78.43%   +0.43%     
==========================================
  Files           1        1              
  Lines          50       51       +1     
  Branches       15       15              
==========================================
+ Hits           39       40       +1     
  Misses          7        7              
  Partials        4        4
Impacted Files Coverage Δ
src/components/Paginate.vue 78.43% <100%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16fc507...6500bda. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #117 into master will increase coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   78.00%   78.43%   +0.43%     
==========================================
  Files           1        1              
  Lines          50       51       +1     
  Branches       15       15              
==========================================
+ Hits           39       40       +1     
  Misses          7        7              
  Partials        4        4              
Impacted Files Coverage Δ
src/components/Paginate.vue 78.43% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16fc507...a9cdf09. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants