Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore internal changes Version 0.0.2 #9

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Ignore internal changes Version 0.0.2 #9

merged 2 commits into from
Oct 26, 2023

Conversation

ralongit
Copy link
Collaborator

  • Ignore internal kubernetes system events that modify only the status, revision & managed fields of the resources.
    • I added a test for it
  • Log to console internal logs instead of shipping/printing them.
  • Modify event message for cluster level resources(ignore namespace).
  • Disable sender debug mode
  • Reorder informer cache sync
  • Better error handling

@ralongit
Version 0.0.2
362ed6b 
- Ignore kubernetes system events that modify only the status of the resources.
  - I added a test for it
- Log to console internal logs instead of shipping/printing them.
- Modify event message for cluster level resources(ignore namespace).
- Disable sender debug mode
- Reorder informer cache sync
- Better error handling
@ralongit ralongit requested a review from mirii1994 October 25, 2023 16:12
mirii1994
mirii1994 suggested changes Oct 26, 2023
View reviewed changes
Copy link

@mirii1994 mirii1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

common/parser.go Outdated Show resolved Hide resolved
common/parser.go Outdated Show resolved Hide resolved
resources/clusterResources.go Outdated Show resolved Hide resolved
resources/resourceInformer.go Outdated Show resolved Hide resolved
@ralongit
Improve code readability
8104c3c 
- Use consts instead of static strings
- Use a variable to check for resource not found errors
- Rename a variable
@ralongit ralongit requested a review from mirii1994 October 26, 2023 08:15
@ralongit ralongit merged commit 8ca0d99 into master Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirii1994 mirii1994 mirii1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralongit @mirii1994