[Release] v0.3.0 #61
[Release] v0.3.0 #61
Conversation
| } | ||
|
|
||
| type SubscriptionFilterEvent struct { | ||
| Detail Detail `json:"detail"` |
There was a problem hiding this comment.
what is the advantage of having this struct instead of using Detail Detail
There was a problem hiding this comment.
I think it's making it more ordered and clear, because without it the NewSubscriptionFilterEvent function looks a bit messy:
func NewSubscriptionFilterEvent(params RequestParameters) struct {
Detail Detail `json:"detail"`
} {
return struct {
Detail Detail `json:"detail"`
}{
Detail: Detail{
EventName: "SubscriptionFilterEvent",
RequestParameters: params,
},
}
}what do you think?
| added := make([]string, 0, len(logGroups)) | ||
| var result *multierror.Error | ||
|
|
||
| var wg sync.WaitGroup |
There was a problem hiding this comment.
Why not a part of the struct like the mutex?
There was a problem hiding this comment.
updateSubscriptionFilters method performs both add and delete operations, and we run each of them separately to manage the concurrent calls to AWS (because for large amount of log groups it may be high in each operation). So running them independently helps reduce the overall concurrency, which means each needs it's own wait group
Description
this pr closes #49 closes #50, closes #52, closes #58, closes #59
eventbridge-lambda>>log-group-events-lambdacommonandcfn-lambdaintolog-group-events-lambdaSubscriptionFilterEventevent type, which is structured based on the EventBridge events formatThrottlingException: Rate exceedederrorCustomLogGroupsvia wildcard (e.g,prefix*)What type of PR is this?
(check all applicable)
Added tests?