Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java OTEL SDK example #729

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Fix Java OTEL SDK example #729

merged 2 commits into from
Dec 22, 2024

Conversation

8naama
Copy link
Contributor

@8naama 8naama commented Dec 22, 2024

  • Add note that the guide only refers to LogBack Appender, but OTEL Also has an appender for Log4j.. to allow users who use log4j to use it instead
  • remove unnecessary full pom.xml from the guide and leave only the required dependencies section (users who want a full example can refer to the linked examples repo.. and that pom we gave is containing application specific information such as a name, version, application main class executable for the build..)
  • Fix shipping token not getting auto-rendered properly in the app

Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for deluxe-empanada-3ebf3b ready!

Name Link
🔨 Latest commit 9ba13ad
🔍 Latest deploy log https://app.netlify.com/sites/deluxe-empanada-3ebf3b/deploys/6767f36074735800089115f6
😎 Deploy Preview https://deploy-preview-729--deluxe-empanada-3ebf3b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bardabun bardabun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@8naama 8naama merged commit 4e70f9d into master Dec 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants