Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP docs #316

Closed
wants to merge 9 commits into from
Closed

GCP docs #316

wants to merge 9 commits into from

Conversation

nico-shishkin
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for shiny-alfajores-ede8d8 failed.

Name Link
🔨 Latest commit e4b8e64
🔍 Latest deploy log https://app.netlify.com/sites/shiny-alfajores-ede8d8/deploys/6570fd2360519900087a96e2

docs/_include/general-shipping/gcp.md Outdated Show resolved Hide resolved



{@include: ../../_include/general-shipping/gcp.md}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we both add the include, and also add the specific value for telemetry_list that will allow shipping metrics for this specific service?
This comment applies to all the documents in this PR.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for deluxe-empanada-3ebf3b ready!

Name Link
🔨 Latest commit 1122dc5
🔍 Latest deploy log https://app.netlify.com/sites/deluxe-empanada-3ebf3b/deploys/65ba33a2feb1790008b79fbb
😎 Deploy Preview https://deploy-preview-316--deluxe-empanada-3ebf3b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nico-shishkin
Copy link
Contributor Author

Hi @mirii1994 , I've resolved the comments, I believe

@mirii1994
Copy link
Contributor

mirii1994 commented Jan 31, 2024

@nico-shishkin I'm closing this PR because there's an issue with the Netlify preview, i'll open a new one instead (#392 )

@mirii1994 mirii1994 closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants