Control plane logs #235
Merged
Control plane logs #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiny-alfajores-ede8d8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mirii1994
suggested changes
Oct 31, 2023
Comment on lines
36
to
39
| 6. Paste `<<LOG-SHIPPING-TOKEN>>` into the content text box. | ||
| 7. Click **Create**. | ||
|
|
||
| {@include: ../../_include/log-shipping/log-shipping-token.html} |
There was a problem hiding this comment.
The placeholder will probably look ok in the app, but it looks a little funny in the public docs, because it looks just like this <> without any explanation that this is a logzio log shipping token.
| spec: | ||
| logging: | ||
| logzio: | ||
| credentials: //secret/<<LOG-SHIPPING-TOKEN>> |
There was a problem hiding this comment.
Is this right? If we stored the shipping token as a secret, I don't think that you're expected to write it explicitly here, I would assume that you'd need to write the name of the opaque secret you created in the first step.
Can you please check this part?
There was a problem hiding this comment.
Correct, it's the secret's name that we need to specify, not the token!
mirii1994
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.