fix create_if_deleted logic by closing the file handle, Closes #81 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
sarkortrantor
force-pushed
the
fix-delete-logic-close-handle
branch
from
a898093 to
8d7243e
Compare
sarkortrantor
force-pushed
the
fix-delete-logic-close-handle
branch
from
8d7243e to
af158c0
Compare
sarkortrantor
changed the title
|
Hello team, Any feedback on the PR, can I do something ? BR |
|
Up |
This was referenced Nov 26, 2021
|
Hello team / @roaksoax , Any feedback on the PR, can I do something ? I think it can close up to 3 related issues. (we use the patch in production since one year now) BR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/