Backport/fix when file is gone #22
Conversation
…th this change the deleted file can either be recreated or the events appended to the errorlog Conflicts: lib/logstash/outputs/file.rb
…the use of concurrent-ruby 0.9.1
|
@purbon as discussed in elastic/logstash#4236 and elastic/logstash#4188 having these versions in the gemspec is not the correct solution. for now I suggest you just put these in the main |
…nforced the use of concurrent-ruby 0.9.1" This reverts commit 527e3ef.
… Gemfile as requested during review until the right expressions are agreed to be placed in the gemspec file
|
@colinsurprenant @jordansissel or @ph can one of you please validate this and give me your opinion. thanks a lot. |
|
@purbon I don't think we need to push a new |
|
@colinsurprenant sorry, still not agreed that |
|
@colinsurprenant I pushed the gemfile because I understood is necessary to let this plugin work for now, right? I do really would like to unblock the backport and agree on a way to go. |
|
@purbon the Gemfile is only necessary for local development work. updated elastic/logstash#4236 to try and explain my point of view. think about it. |
|
@colinsurprenant I made the changes as discussed. I keep the Gemfile with the concurrent ruby fix as is required for dev env to not be broken. let me know what do you think? |
Backport #21, notice a few things need to do to make the backport compatible.
s.add_runtime_dependency "logstash-core", '~> 1.4'as the former expression was fetching 2.0.0 pre releases that are basically imcompatible with this branch of code.concurrent-rubyversion to0.9.1, this is needed as the fix was not backported to 1.5.for the rest the backport is good and working. please check #21 and #20 if you need more clarifications to what this changes are doing.
Fixes #20 for 1.x plugins.