Backport/metadata handling issue fixed in master #24
Conversation
… necessary metadata fields
|
@jsvd can you let me know your thought on this backport? |
| @@ -20,7 +20,7 @@ Gem::Specification.new do |s| | |||
| s.metadata = { "logstash_plugin" => "true", "logstash_group" => "filter" } | |||
|
|
|||
| # Gem dependencies | |||
| s.add_runtime_dependency "logstash-core", '>= 1.4.0', '< 2.0.0' | |||
| s.add_runtime_dependency "logstash-core", '>= 1.4.0', '< 1.999.0' | |||
There was a problem hiding this comment.
maybe s.add_runtime_dependency "logstash-core", '>= 1.4.0', '~> 1' ?
There was a problem hiding this comment.
@jsvd It was agreed with @colinsurprenant this was the right way to follow. There is an issue in core for this.
There was a problem hiding this comment.
see elastic/logstash#4236 for details.
|
Code LGTM, but we need to address the concurrent-ruby version problem before merging.. |
|
@jsvd as it's right now the gemfile is only helping on development environment. It will be harmless when installing the plugin/gem. what do you think? |
|
but doing bundle install && bundle exec rspec will break as soon as 1.5.6 is released, right? |
|
well I guess as soon as 1.5.6 gets released we don't need this anymore. what do you think? |
|
ahh because 1.5.6 pins a specific version of concurrent-ruby instead of ~0.9.1? |
|
+1 on removing the concurrent-ruby pinning |
|
ah and please change the logstash-core dependency to < 2.0.0.alpha0 ? |
|
works for me, thanks for your feedback. |
updated the logstash core requirement to < 2.0.0.alpha0
Backport/metadata handling issue fixed in master
Fixes #19 and #22 for the core-api-v1 (aka 1.x logstash-core) series of plugins.