fix: hide "intercept response" checkbox in response view (#113)

loderunner · Mar 1, 2022 · 1a52cd5 · 1a52cd5
1 parent 0c0f90c
commit 1a52cd5
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 20 deletions.
diff --git a/src/panel/RequestBody.tsx b/src/panel/RequestBody.tsx
@@ -65,7 +65,7 @@ const RequestBody = ({ requestId, className = '' }: Props) => {
   }, [contentType, onChangeBody, request.id, request.postData])
 
   return (
-    <div className={`mt-8 flex flex-col justify-items-stretch ${className}`}>
+    <div className={`flex flex-col justify-items-stretch ${className}`}>
       {bodyView}
     </div>
   )

diff --git a/src/panel/RequestView.tsx b/src/panel/RequestView.tsx
@@ -29,11 +29,11 @@ const RequestView = ({ requestId }: Props) => {
     () => (
       <>
         <RequestDetails
-          className={tab === 'headers' ? '' : 'hidden'}
+          className={`mt-8 ${tab === 'headers' ? '' : 'hidden'}`}
           requestId={requestId}
         />
         <RequestBody
-          className={tab === 'body' ? '' : 'hidden'}
+          className={`mt-8 ${tab === 'body' ? '' : 'hidden'}`}
           requestId={requestId}
         />
       </>
@@ -73,14 +73,16 @@ const RequestView = ({ requestId }: Props) => {
   return (
     <div className="max-w-5xl mx-24 my-8 px-8 pt-2">
       <div className="flex space-x-4 mb-4">{buttons}</div>
-      <label className="mt-1 inline-flex items-center">
-        <input
-          type="checkbox"
-          checked={request.interceptResponse}
-          onChange={onToggleInterceptResponse}
-        />
-        <span className="ml-1 text-sm text-gray-700">Intercept response</span>
-      </label>
+      {request.stage !== 'Response' ? (
+        <label className="mt-1 inline-flex items-center">
+          <input
+            type="checkbox"
+            checked={request.interceptResponse}
+            onChange={onToggleInterceptResponse}
+          />
+          <span className="ml-1 text-sm text-gray-700">Intercept response</span>
+        </label>
+      ) : null}
       {content}
     </div>
   )

diff --git a/src/panel/__tests__/__snapshots__/Main.tsx.snap b/src/panel/__tests__/__snapshots__/Main.tsx.snap
@@ -149,7 +149,7 @@ exports[`[Main] should match request selection snapshot 1`] = `
         </span>
       </label>
       <div
-        class=""
+        class="mt-8 "
       >
         <span
           class="text-3xl font-bold"
@@ -429,7 +429,7 @@ exports[`[Main] should match request selection snapshot 1`] = `
         </div>
       </div>
       <div
-        class="mt-8 flex flex-col justify-items-stretch hidden"
+        class="flex flex-col justify-items-stretch mt-8 hidden"
       >
         <div
           class="relative -ml-4"

diff --git a/src/panel/__tests__/__snapshots__/RequestBody.tsx.snap b/src/panel/__tests__/__snapshots__/RequestBody.tsx.snap
@@ -3,7 +3,7 @@
 exports[`[RequestBody] should match initial snapshot 1`] = `
 <div>
   <div
-    class="mt-8 flex flex-col justify-items-stretch "
+    class="flex flex-col justify-items-stretch "
   >
     <div
       class="relative -ml-4"

diff --git a/src/panel/__tests__/__snapshots__/RequestView.tsx.snap b/src/panel/__tests__/__snapshots__/RequestView.tsx.snap
@@ -33,7 +33,7 @@ exports[`[RequestView] should match body snapshot 1`] = `
       </span>
     </label>
     <div
-      class="hidden"
+      class="mt-8 hidden"
     >
       <span
         class="text-3xl font-bold"
@@ -313,7 +313,7 @@ exports[`[RequestView] should match body snapshot 1`] = `
       </div>
     </div>
     <div
-      class="mt-8 flex flex-col justify-items-stretch "
+      class="flex flex-col justify-items-stretch mt-8 "
     >
       <div
         class="relative -ml-4"
@@ -1080,7 +1080,7 @@ exports[`[RequestView] should match headers snapshot 1`] = `
       </span>
     </label>
     <div
-      class=""
+      class="mt-8 "
     >
       <span
         class="text-3xl font-bold"
@@ -1360,7 +1360,7 @@ exports[`[RequestView] should match headers snapshot 1`] = `
       </div>
     </div>
     <div
-      class="mt-8 flex flex-col justify-items-stretch hidden"
+      class="flex flex-col justify-items-stretch mt-8 hidden"
     >
       <div
         class="relative -ml-4"
@@ -2127,7 +2127,7 @@ exports[`[RequestView] should match initial snapshot 1`] = `
       </span>
     </label>
     <div
-      class=""
+      class="mt-8 "
     >
       <span
         class="text-3xl font-bold"
@@ -2407,7 +2407,7 @@ exports[`[RequestView] should match initial snapshot 1`] = `
       </div>
     </div>
     <div
-      class="mt-8 flex flex-col justify-items-stretch hidden"
+      class="flex flex-col justify-items-stretch mt-8 hidden"
     >
       <div
         class="relative -ml-4"