make the ephemeral startup configurable for users #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ephemeral instance for the application preview has been shut down |
HarshCasper
force-pushed
the
config-option
branch
8 times, most recently
from
5f60e10 to
d20755a
Compare
HarshCasper
force-pushed
the
config-option
branch
from
d20755a to
ef89543
Compare
lukqw
reviewed
Oct 29, 2024
| @@ -23,7 +23,10 @@ inputs: | |||
| description: 'The lifetime of the ephemeral instance, how long the instance should be available for' | |||
| required: false | |||
| default: '30' | |||
|
|
|||
| ephemeral-configuration: | |||
There was a problem hiding this comment.
would it make more sense to keep this as configuration, similar to what we have in place over in the normal startup action? link: https://github.com/localstack/setup-localstack/blob/main/startup/action.yml
If not, then you'd also have to reflect this argument in the README.
There was a problem hiding this comment.
Furthermore this would have to be added in the main action: https://github.com/localstack/setup-localstack/blob/main/action.yml#L138
Comment on lines
+76
to
+89
| configuration="${{ inputs.ephemeral-configuration }}" | ||
| echo "Creating preview environment with configuration: $configuration" | ||
| # Convert configuration to JSON format | ||
| IFS=',' read -r -a configArray <<< "$configuration" | ||
| envVarsJson=$(jq -n '{}') | ||
| for config in "${configArray[@]}"; do | ||
| IFS='=' read -r -a kv <<< "$config" | ||
| key=${kv[0]// /} | ||
| value=${kv[1]// /} | ||
| envVarsJson=$(echo $envVarsJson | jq --arg key "$key" --arg value "$value" '. + {($key): $value}') | ||
| done | ||
| echo "Configuration JSON: $envVarsJson" | ||
|
|
||
| envVarsJson=$(echo $envVarsJson | jq --arg autoLoadPod "$autoLoadPod" --arg extensionAutoInstall "$extensionAutoInstall" '. + {AUTO_LOAD_POD: $autoLoadPod, EXTENSION_AUTO_INSTALL: $extensionAutoInstall}') |
There was a problem hiding this comment.
this is oddly convoluted, is there a way we could improve readability and maintenance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.