create pdf out of the documentation #930
Conversation
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-930.surge.sh 🎊 |
There was a problem hiding this comment.
Looks great, kudos for putting this together so quickly @HarshCasper ! 🚀
Added a few tiny comments, nothing that should block the merge..
Small note: seems like the border on the PDF pages is pretty small, hence the content sits very much at the top of the page (at least in my PDF reader). No need to change it for now though, could be done in a future iteration. 👍
Example 1:
Example 2:
| 'developing-extensions', | ||
| 'official-extensions', | ||
| 'cloud-pods', | ||
| 'getting-started', |
There was a problem hiding this comment.
seems to be a duplicate with line 125 - on purpose?
There was a problem hiding this comment.
Seems like a bug. Will fix later in follow-up PR
| source_directory = "w2pdf_output" | ||
| target_directory = "final" | ||
| find_and_copy_pdfs(source_directory, target_directory) | ||
| merge_pdfs(doc_list, "localstack_docs.pdf") |
There was a problem hiding this comment.
nit: we could add a small check to discover pages that are contained in the target_directory, but not contained in doc_list (and then either print a warning, or fail the script), to make it easier to maintain the list in pdf_list.py over time. (not super critical for now, though..)
There was a problem hiding this comment.
Yeah, will follow up on the other PR 👍
No description provided.