Fix sqs coverage #915
Merged
Fix sqs coverage #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy PR Preview failed. |
steffyP
force-pushed
the
fix-sqs-query-coverage
branch
from
7204577 to
7edacfb
Compare
bentsku
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the json protocol for SQS and the fix in LocalStack, the coverage update from this week was showing
sqs-queryandsqsas two different services.However, showing the coverage like this doesn't make sense.
This PR adapts the coverage-scripts so that
sqs-querywill not be listed as a separate service, and all metrics recorded for servicesqs-querywill be added to thesqsservice.Started a test run with the feature branch, resulting in this PR, where we don't see service
sqs-queryanymore.