Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Elasticache provider #894

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Conversation

viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Nov 7, 2023

This PR adds additional examples to illustrate the abilities of the new ElastiCache provider.

@viren-nadkarni viren-nadkarni self-assigned this Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-894.surge.sh 🎊

@viren-nadkarni viren-nadkarni mentioned this pull request Nov 8, 2023
15 tasks
@viren-nadkarni viren-nadkarni force-pushed the elasticache-deprecation branch from a44edde to 6022274 Compare November 8, 2023 07:05
@viren-nadkarni viren-nadkarni marked this pull request as ready for review November 8, 2023 12:45
@dominikschubert dominikschubert self-requested a review November 8, 2023 22:28
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can judge it 👍

I've added a few suggestions to replace the usage of jq in favor of the native JMESPath query.

@@ -247,7 +253,7 @@ The old lambda provider is temporarily available in Localstack v2 using `PR
| - | - | - |
| `SQS_DELAY_PURGE_RETRY` | `0` (default) | Used to toggle PurgeQueueInProgress errors when making more than one PurgeQueue call within 60 seconds. |
| `SQS_DELAY_RECENTLY_DELETED` | `0` (default) | Used to toggle QueueDeletedRecently errors when re-creating a queue within 60 seconds of deleting it. |
| `SQS_ENDPOINT_STRATEGY`| `domain`\|`path`\|`off` | Configures the format of Queue URLs (see [SQS Queue URLs]({{< ref "sqs#queue-urls" >}})) |
| `SQS_ENDPOINT_STRATEGY`| `standard` (default) \| `domain` \| `path` \| `off` | Configures the format of Queue URLs (see [SQS Queue URLs]({{< ref "sqs#queue-urls" >}})) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaky

content/en/user-guide/aws/elasticache/index.md Outdated Show resolved Hide resolved
content/en/user-guide/aws/elasticache/index.md Outdated Show resolved Hide resolved
content/en/user-guide/aws/elasticache/index.md Outdated Show resolved Hide resolved
@alexrashed alexrashed force-pushed the elasticache-deprecation branch from 76a971f to e84eb85 Compare November 9, 2023 06:13
Co-authored-by: Dominik Schubert <[email protected]>
@viren-nadkarni viren-nadkarni merged commit 23ecadc into release/v3.0 Nov 9, 2023
2 checks passed
@viren-nadkarni viren-nadkarni deleted the elasticache-deprecation branch November 9, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants