Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS: Add new endpoint strategy #877

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Oct 25, 2023

This PR updates user docs with details about the new SQS endpoint strategy

Depends on localstack/localstack-artifacts#20

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-877.surge.sh 🎊

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the one hand, this PR depends on localstack/localstack-artifacts#20 (because before that the endpoints cannot be properly used with HTTPS enabled), and the advertisement of the new endpoint strategy also depends on how you decide to rename them for v3:
localstack/localstack#9454 (review)
Are you going to rename them from domain to legacy, and then renaming standard to domain. Because if so, I would not add this to the docs like this right now, but wait for the release and describe the new way (otherwise users who switch to standard now, will experience a breaking change with 3.0).

@viren-nadkarni
Copy link
Member Author

Are you going to rename them from domain to legacy, and then renaming standard to domain. Because if so, I would not add this to the docs like this right now, but wait for the release and describe the new way (otherwise users who switch to standard now, will experience a breaking change with 3.0).

I'm against renaming the existing strategies to avoid confusion among users. It is possible that we might also break user workflows in doing so.

@alexrashed
Copy link
Member

That's a good argument! But then let's still wait for the cert to be updated before we advertise the new endpoint strategy...

@viren-nadkarni viren-nadkarni merged commit 0f2131d into main Nov 6, 2023
3 checks passed
@viren-nadkarni viren-nadkarni deleted the sqs-standard-strategy branch November 6, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants