Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat transparent endpoint injection docs #866

Closed
wants to merge 1 commit into from

Conversation

HarshCasper
Copy link
Member

No description provided.

@HarshCasper HarshCasper requested a review from simonrw October 17, 2023 08:08
@github-actions
Copy link

⚡️ Deploying PR Preview...

@simonrw
Copy link
Contributor

simonrw commented Oct 27, 2023

@HarshCasper there are quite a few build errors showing up. I'm happy to review once these errors have been fixed.

@joe4dev
Copy link
Member

joe4dev commented Nov 8, 2023

oh, I just spotted this one after doing the migration for removing the legacy lambda provider and updating some content to adopt AWS_ENDPOINT_URL in #899

Integrating the sub-page makes sense now that we only have one unless we treat the new AWS_ENDPOINT_URL as a separate way of transparent endpoint injection 🤔

@simonrw
Copy link
Contributor

simonrw commented Nov 30, 2023

@HarshCasper @joe4dev is this PR still valid given #941?

@joe4dev
Copy link
Member

joe4dev commented Dec 1, 2023

I think this is obsolete now with the complete rework in #941

@HarshCasper nicely spotted a legacy redirect we should add to the Transparent Endpoint Injection page:

- /user-guide/tools/transparent-endpoint-injection/patched-sdks/

I added it as a local edit planning to sneak it into a future PR but feel to sneak it into localstack/localstack#9692 @simonrw

Closing this for now. @HarshCasper Feel free to revive or re-structure once you are going to unify the page structure under tools.

@joe4dev joe4dev closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants